LegacyConsole/4jcraft
4
0
Fork 0
mirror of https://git.huckle.dev/Huckles-Minecraft-Archive/4jcraft.git synced 2026-06-11 10:42:12 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix: Ensure host-local socket streams created before any Connection is built

Browse Source
This commit is contained in:
JuiceyDev
2026-03-06 12:10:39 +01:00
parent b589b86f40
commit cdb02fa0af
3 changed files with 46 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
Minecraft.Client/Build/Common/Network/GameNetworkManager.cpp
View File

@@ -212,6 +212,17 @@ bool CGameNetworkManager::StartNetworkGame(Minecraft *minecraft, LPVOID lpParame
}
static __int64 sseed = seed; // Create static version so this will be valid until next call to this function & whilst thread is running
// 4J Fix: Ensure host-local socket streams (s_hostInStream / s_hostOutStream) are always
// created before any Socket or Connection objects are allocated. Socket::Initialise normally
// runs on the server thread, but on certain builds the main thread can reach ClientConnection
// creation before that thread has a chance to execute, leaving the stream arrays NULL.
// Calling Initialise(NULL) here (with the server connection unknown yet) will create the
// stream objects on the very first call; all subsequent calls only reset the queue state.
// The server thread's later Initialise(connection) call will then correctly update
// s_serverConnection without touching the already-allocated stream objects.
Socket::Initialise(NULL);
ServerStoppedCreate(false);
if( g_NetworkManager.IsHost() )
{