From 5f931d74fce13092fd8da50f0b601a4d1b2798d1 Mon Sep 17 00:00:00 2001 From: Loki Rautio Date: Wed, 29 Apr 2026 17:02:40 -0500 Subject: [PATCH 1/4] Update 4JLibs, adjust README --- Minecraft.Client/Windows64/4JLibs | 2 +- README.md | 10 ++-------- 2 files changed, 3 insertions(+), 9 deletions(-) diff --git a/Minecraft.Client/Windows64/4JLibs b/Minecraft.Client/Windows64/4JLibs index f567d33c..8fb036f6 160000 --- a/Minecraft.Client/Windows64/4JLibs +++ b/Minecraft.Client/Windows64/4JLibs @@ -1 +1 @@ -Subproject commit f567d33ccbddad1d8356e4d8344b22de80f23ab2 +Subproject commit 8fb036f6d6ca5aa5aa2e20633638d6232a58d508 diff --git a/README.md b/README.md index 560a798a..db73f7f0 100644 --- a/README.md +++ b/README.md @@ -3,13 +3,6 @@ [![Discord](https://img.shields.io/badge/Discord-Join%20Server-5865F2?logo=discord&logoColor=white)](https://discord.gg/dH8AZWGcau) ---- -## IMPORTANT UPDATE -**This repo was moved to a new org!** - -Please change all links and references from `smartcmd/MinecraftConsoles` to `MCLCE/MinecraftConsoles` instead. - ---- This project is based on source code of Minecraft Legacy Console Edition v1.6.0560.0 (TU19) with some fixes and improvements applied. @@ -213,7 +206,8 @@ Persistent files are bind-mounted to host: ## Build & Run 1. Install [Visual Studio 2022](https://aka.ms/vs/17/release/vs_community.exe) or [newer](https://visualstudio.microsoft.com/downloads/). -2. Clone the repository. +2. Clone the repository with submodules. If you don't, you will get a build error! + - `git clone --recurse-submodules https://github.com/MCLCE/MinecraftConsoles.git` 3. Open the project folder from Visual Studio. 4. Set the build configuration to **Windows64 - Debug** (Release is also ok but missing some debug features), then build and run. From 5bccf89fe237937f2b0b5490baf6b59759ed8423 Mon Sep 17 00:00:00 2001 From: Loki Date: Thu, 30 Apr 2026 13:21:25 -0500 Subject: [PATCH 2/4] Update COMPILE.md --- COMPILE.md | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/COMPILE.md b/COMPILE.md index 7d46f340..c3c5212a 100644 --- a/COMPILE.md +++ b/COMPILE.md @@ -2,13 +2,14 @@ ## Visual Studio -1. Clone or download the repository -1. Open the repo folder in Visual Studio 2022+. -2. Wait for cmake to configure the project and load all assets (this may take a few minutes on the first run). -3. Right click a folder in the solution explorer and switch to the 'CMake Targets View' -4. Select platform and configuration from the dropdown. EG: `Windows64 - Debug` or `Windows64 - Release` -5. Pick the startup project `Minecraft.Client.exe` or `Minecraft.Server.exe` using the debug targets dropdown -6. Build and run the project: +1. Clone the repo, including submodules. + - If you don't, the build will fail. `git clone --recurse-submodules https://github.com/MCLCE/MinecraftConsoles.git` +2. Open the repo folder in Visual Studio 2022+. +3. Wait for cmake to configure the project and load all assets (this may take a few minutes on the first run). +4. Right click a folder in the solution explorer and switch to the 'CMake Targets View' +5. Select platform and configuration from the dropdown. EG: `Windows64 - Debug` or `Windows64 - Release` +6. Pick the startup project `Minecraft.Client.exe` or `Minecraft.Server.exe` using the debug targets dropdown +7. Build and run the project: - `Build > Build Solution` (or `Ctrl+Shift+B`) - Start debugging with `F5`. From d3df53503ac8adf640a96249a6854fc5495d2e4c Mon Sep 17 00:00:00 2001 From: Loki Date: Thu, 30 Apr 2026 13:21:31 -0500 Subject: [PATCH 3/4] Update COMPILE.md --- COMPILE.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/COMPILE.md b/COMPILE.md index c3c5212a..05bf0898 100644 --- a/COMPILE.md +++ b/COMPILE.md @@ -3,7 +3,7 @@ ## Visual Studio 1. Clone the repo, including submodules. - - If you don't, the build will fail. `git clone --recurse-submodules https://github.com/MCLCE/MinecraftConsoles.git` + - If you don't, the build will fail. `git clone --recurse-submodules https://github.com/MCLCE/MinecraftConsoles.git` 2. Open the repo folder in Visual Studio 2022+. 3. Wait for cmake to configure the project and load all assets (this may take a few minutes on the first run). 4. Right click a folder in the solution explorer and switch to the 'CMake Targets View' From 09df8928eeb15328bca499d225e48ea95af6d119 Mon Sep 17 00:00:00 2001 From: Alex <56621824+dognews@users.noreply.github.com> Date: Mon, 4 May 2026 15:00:40 -0700 Subject: [PATCH 4/4] fix: Properly load and restore the metadata for saves (#1550) * fix: save metadata loading Notify others that the thumbnail data is loaded. Refs: #124 * refactor: remove redundant class field --- Minecraft.Client/Common/UI/UIScene_LoadMenu.cpp | 4 +--- Minecraft.Client/Common/UI/UIScene_LoadMenu.h | 1 - 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/Minecraft.Client/Common/UI/UIScene_LoadMenu.cpp b/Minecraft.Client/Common/UI/UIScene_LoadMenu.cpp index 0e858213..d87aef57 100644 --- a/Minecraft.Client/Common/UI/UIScene_LoadMenu.cpp +++ b/Minecraft.Client/Common/UI/UIScene_LoadMenu.cpp @@ -53,7 +53,6 @@ int UIScene_LoadMenu::LoadSaveDataThumbnailReturned(LPVOID lpParam,PBYTE pbThumb app.DebugPrintf("Thumbnail data is nullptr, or has size 0\n"); pClass->m_bThumbnailGetFailed = true; } - pClass->m_bRetrievingSaveThumbnail = false; } return 0; @@ -100,7 +99,6 @@ UIScene_LoadMenu::UIScene_LoadMenu(int iPad, void *initData, UILayer *parentLaye m_bIsSaveOwner = true; m_bSaveThumbnailReady = false; - m_bRetrievingSaveThumbnail = true; m_bShowTimer = false; m_pDLCPack = nullptr; m_bAvailableTexturePacksChecked=false; @@ -274,9 +272,9 @@ UIScene_LoadMenu::UIScene_LoadMenu(int iPad, void *initData, UILayer *parentLaye m_bitmapIcon.setTextureName(wFilename); m_pbThumbnailData = params->saveDetails->pbThumbnailData; m_uiThumbnailSize = params->saveDetails->dwThumbnailSize; + m_bSaveThumbnailReady = true; } - m_bRetrievingSaveThumbnail = false; } #endif } diff --git a/Minecraft.Client/Common/UI/UIScene_LoadMenu.h b/Minecraft.Client/Common/UI/UIScene_LoadMenu.h index 53d66d55..5b2b3435 100644 --- a/Minecraft.Client/Common/UI/UIScene_LoadMenu.h +++ b/Minecraft.Client/Common/UI/UIScene_LoadMenu.h @@ -50,7 +50,6 @@ private: int m_iGameModeId; bool m_bHasBeenInCreative; bool m_bIsSaveOwner; - bool m_bRetrievingSaveThumbnail; bool m_bSaveThumbnailReady; bool m_bMultiplayerAllowed; bool m_bShowTimer;