LegacyConsole/jpexs-decompiler
3
0
Fork 0
mirror of https://git.huckle.dev/Huckles-Minecraft-Archive/jpexs-decompiler.git synced 2026-05-30 20:27:44 +00:00
Code Issues Packages Projects Releases Wiki Activity

NPE on runtime when installedFontsByFamily is null (#73)

Browse Source 
* NPE on runtime when installedFontsByFamily is `null`

When running the command `java -jar dist/ffdec.jar -export fla <out> <file.swf>`, it crashes with stacktrace:
```
java.lang.NullPointerException                                                                                                                                                                                                                                           
        at com.jpexs.decompiler.flash.tags.base.FontTag.isFontFamilyInstalled(FontTag.java:310)                                                                                                                                                                          
        at com.jpexs.decompiler.flash.xfl.XFLConverter.convertFonts(XFLConverter.java:2366)                                                                                                                                                                              
        at com.jpexs.decompiler.flash.xfl.XFLConverter.convertSWF(XFLConverter.java:3363)
        at com.jpexs.decompiler.flash.SWF.exportXfl(SWF.java:2506)
        at com.jpexs.decompiler.flash.console.CommandLineArgumentParser.exportFla(CommandLineArgumentParser.java:2410)
        at com.jpexs.decompiler.flash.console.CommandLineArgumentParser.parseExport(CommandLineArgumentParser.java:2349)
        at com.jpexs.decompiler.flash.console.CommandLineArgumentParser.parseArguments(CommandLineArgumentParser.java:891)
        at com.jpexs.decompiler.flash.gui.Main.main(Main.java:1976)

```

Null checking `installedFontsByFamily` fixes the issue and the SWF to FLA is successful.

* Add ensureLoaded()  for isFontFamilyInstalled

With ensureLoaded() instead of null check
This commit is contained in:
florent.fauchille
2019-03-07 10:39:27 +01:00
committed by Jindra Petřík
parent 5733cd9051
commit 419fd9590e
1 changed files with 1 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
libsrc/ffdec_lib/src/com/jpexs/decompiler/flash/tags/base/FontTag.java
View File

@@ -306,6 +306,7 @@ public abstract class FontTag extends DrawableTag implements AloneTag {
}
public static String isFontFamilyInstalled(String fontFamily) {
ensureLoaded();
if (installedFontsByFamily.containsKey(fontFamily)) {
return fontFamily;
}