comment explains it, maybe should be removed?

(cherry picked from commit 474b9030c1c24d2e90dddbdc17d6c32c043e3f6c)
This commit is contained in:
Enrico Zeilmaker
2023-08-01 03:02:57 +02:00
committed by Jindra Petřík
parent 68f5c62fd2
commit a0044d54b3

View File

@@ -226,7 +226,7 @@ public class TraitSlotConst extends Trait implements TraitWithSlot {
if (ignorePackage == null) {
ignorePackage = getPackage(abc);
}
super.getDependencies(abcIndex, scriptIndex, classIndex, isStatic, customNs, abc, dependencies, ignorePackage, fullyQualifiedNames);
super.getDependencies(abcIndex, scriptIndex, classIndex, isStatic, customNs, abc, dependencies, ignorePackage, fullyQualifiedNames); // I don't think this is necessary? It causes class variable names to be listed as dependencies, but their DottedChain consists of only 1 part, which gets categorized as a root package and filtered from imports. Unless I'm missing something, this is wrong but it doesn't break anything
DependencyParser.parseDependenciesFromMultiname(abcIndex, customNs, abc, dependencies, abc.constants.getMultiname(type_index), getPackage(abc), fullyQualifiedNames, DependencyType.SIGNATURE);
}