Nikita Edel
69a8ce84b9
giant batch BOOOOM
2026-03-11 17:28:13 +01:00
Nikita Edel
ed13020cf3
s integer overflow, unsafe cast
2026-03-11 16:10:48 +01:00
Nikita Edel
a24f9f5a5e
better rounding and s int overflow
2026-03-11 14:21:04 +01:00
MathiewMay
e36e58609d
Reverted the SetEntityMotionPacket.cpp changes
2026-03-11 08:42:19 -04:00
MathiewMay
77deb67b4a
Revert "Rewrote the entity movement packets to use full 16-bit signed short increasing the entity ID limit from 2048 (artifical lce limit) to 32768 ids (0 to 32767)"
...
This reverts commit dac0e883b6
2026-03-11 08:39:22 -04:00
Nikita Edel
8395277c0c
shift of signed int, s int overflow
2026-03-11 13:36:44 +01:00
Nikita Edel
63e4b9b18a
next little patch of ub, unallocated variable, s int overflow
2026-03-11 13:36:44 +01:00
MathiewMay
047615dbbe
Fix entity ID TLS key recreating on every call of getSmallid() for linux, this caused a ID pool corruption.
2026-03-11 08:34:20 -04:00
MathiewMay
702839176e
Revert " applied changes requested by tropicaaal"
...
This reverts commit 41d8202c47
2026-03-11 08:29:24 -04:00
Nikita Edel
11aa08aece
Merge branch '4jcraft:dev' into fix-with-ubsan
2026-03-11 11:57:46 +01:00
notmatthewbeshay
5f8c9c8a25
Merge upstream/dev into issue/51-phase-1-portable-win32-cleanup
2026-03-11 17:09:16 +11:00
Tropical
32bd586c6e
Merge pull request #153 from MathiewMay/dev
...
Changed entity id from 11-bit to 16-bit for movement and motion packets.
2026-03-11 00:31:32 -05:00
Tropical
5b4319556d
refactor: remove redundant casts in MoveEntityPacket
2026-03-11 00:20:23 -05:00
notmatthewbeshay
a503336887
Merge upstream/dev into issue/51-phase-1-portable-win32-cleanup
2026-03-11 16:02:48 +11:00
notmatthewbeshay
dbc8071183
Use standard result types in file helpers
2026-03-11 15:38:53 +11:00
notmatthewbeshay
2256d0fadd
Remove legacy Win32 thread entry state
2026-03-11 15:38:53 +11:00
notmatthewbeshay
78fdd89f9d
Use platform TLS keys in old chunk storage
2026-03-11 15:38:53 +11:00
notmatthewbeshay
a08cb8d190
Use platform TLS keys for entity small IDs
2026-03-11 15:38:53 +11:00
notmatthewbeshay
4e8d1c9e17
Use platform TLS keys in portal and piston state
2026-03-11 15:38:53 +11:00
notmatthewbeshay
b2942ea9d8
Use platform TLS keys in level state
2026-03-11 15:38:53 +11:00
notmatthewbeshay
c2b3537c62
Remove dead Win32 error state from compressed storage
2026-03-11 15:38:53 +11:00
notmatthewbeshay
6185c58203
Use standard callback pointers in sign verification
2026-03-11 15:38:52 +11:00
notmatthewbeshay
ee7945ea54
Use standard locals in storage and connection
2026-03-11 15:38:52 +11:00
notmatthewbeshay
d48bd03722
Use standard byte pointers in decompression helpers
2026-03-11 15:38:52 +11:00
notmatthewbeshay
9d41d3c359
Use fixed-width byte values in world data
2026-03-11 15:38:52 +11:00
notmatthewbeshay
a1fdebbc3b
Use standard skin locals in player code
2026-03-11 15:38:51 +11:00
notmatthewbeshay
377e1d2192
Use standard wide string returns for item descriptions
2026-03-11 15:38:47 +11:00
notmatthewbeshay
f7e6b02835
Use standard callback types in 4J input headers
2026-03-11 15:38:47 +11:00
notmatthewbeshay
d2db55e050
Use standard thumbnail buffer types
2026-03-11 15:38:42 +11:00
notmatthewbeshay
3e89da8dff
Use standard byte buffers for save image metadata
2026-03-11 15:38:42 +11:00
notmatthewbeshay
0437fb921f
Use standard byte counts for base save data
2026-03-11 15:38:42 +11:00
notmatthewbeshay
0ab0fd9209
Standardise fixed-width integer usage in touched files
2026-03-11 15:38:42 +11:00
notmatthewbeshay
83ba8d8384
Use a portable seek origin for save files
2026-03-11 15:38:41 +11:00
notmatthewbeshay
45c22ab6cc
Use bool for save file IO results
2026-03-11 15:38:41 +11:00
Nikita Edel
caadcfe9db
faulty casts of templated classes
2026-03-11 03:45:56 +01:00
Nikita Edel
dfb200d037
integer oferflow, shift of negative value
2026-03-11 00:26:31 +01:00
Nikita Edel
a006cc5aa0
uninitialized vptr
...
the vptr to isSolidRender() is not known before contruction of the Tile. Its true by default. if false, need to pass false. that is what i did. i verfied what isSolidRender() is in every file. and did exactly what isSolidRender() would return
2026-03-10 23:22:34 +01:00
MathiewMay
41d8202c47
applied changes requested by tropicaaal
...
"i would prefer that these be cast to sized integer types int8_t for portability reasons."
"The light layer changes are ultimately a hack over the broken renderer implementation and probably out of scope for this PR. There's an in-progress fix for the root cause of this, so this should be removed."
"std::numeric_limits<int16_t>::max()"
2026-03-10 18:20:33 -04:00
Nikita Edel
af16088015
improved a change
2026-03-10 20:13:01 +01:00
Nikita Edel
f9fc430c43
Merge branch '4jcraft:dev' into dev
2026-03-10 19:34:42 +01:00
MatthewBeshay
2a2558ace3
Merge branch '4jcraft:dev' into issue/51-phase-1-portable-win32-cleanup
2026-03-10 18:39:30 +11:00
MathiewMay
dac0e883b6
Rewrote the entity movement packets to use full 16-bit signed short increasing the entity ID limit from 2048 (artifical lce limit) to 32768 ids (0 to 32767)
2026-03-09 21:45:08 -04:00
Nikita Edel
021c2809f4
purged -Wdelete-non-abstract-non-virtual-dtor
2026-03-10 02:13:56 +01:00
Tropical
e4868446bd
chore: add comments for 4jcraft-added functionality, undo #135
2026-03-09 19:46:54 -05:00
notmatthewbeshay
d1b2b8cedb
Use standard byte counts in save file IO
2026-03-10 10:20:17 +11:00
notmatthewbeshay
8be51f6270
Use standard pointers in save file IO
2026-03-10 10:14:02 +11:00
notmatthewbeshay
2b3c688b44
Use bool for save file close handles
2026-03-10 10:14:02 +11:00
notmatthewbeshay
0db324debd
Remove LPVOID from split save file memory
2026-03-10 10:14:01 +11:00
notmatthewbeshay
647b3c6352
Remove LPVOID from original save file memory
2026-03-10 10:14:01 +11:00
notmatthewbeshay
32773137e1
Remove VOID from compression helpers
2026-03-10 10:14:01 +11:00
Nikita Edel